New: Add no-unreachable-loop rule (fixes #12381)#12660
Merged
Conversation
aladdin-add
reviewed
Jun 7, 2020
Member
|
@mdjermanovic are you still working on this? |
Member
Author
|
Yes, sorry I didn't have much time last week, |
aladdin-add
approved these changes
Jun 12, 2020
Member
aladdin-add
left a comment
There was a problem hiding this comment.
LGTM, thanks! better to have one more reviewer on this~
kaicataldo
approved these changes
Jun 12, 2020
nzakas
approved these changes
Jun 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] New rule
fixes #12381
Examples of incorrect code for this rule:
What changes did you make? (Give an overview)
new rule:
no-unreachable-loopIs there anything you'd like reviewers to focus on?