Fix: CLIEngine#addPlugin reset lastConfigArrays (fixes #12425)#12468
Merged
mysticatea merged 1 commit intomasterfrom Oct 24, 2019
Merged
Fix: CLIEngine#addPlugin reset lastConfigArrays (fixes #12425)#12468mysticatea merged 1 commit intomasterfrom
mysticatea merged 1 commit intomasterfrom
Conversation
platinumazure
approved these changes
Oct 20, 2019
Member
|
@mysticatea Would you like to merge this, or would you prefer that another team member review this? |
Member
Author
|
Thank you for review. I'll merge this. |
This was referenced Nov 9, 2019
This was referenced Mar 11, 2020
This was referenced Mar 26, 2020
This was referenced Apr 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix: #12425
What changes did you make? (Give an overview)
This PR fixes
CLIEngine#addPlugin()method to resetlastConfigArraysinternal state as well. BecauseCLIEngine#getRules()gets plugin rules from thelastConfigArraysinternal state, this reset is needed.Is there anything you'd like reviewers to focus on?
Nothing in particular.