Repository navigation
Handle context for menu items in Tree Views - #11742
Merged
colin-grant-work merged 2 commits intoNov 8, 2022
Merged
colin-grant-work merged 2 commits into
colin-grant-work merged 2 commits into
Conversation
viewItem context on selection
msujew
self-requested a review
October 13, 2022 13:04
colin-grant-work
force-pushed
the
bugfix/parent-context-propagation
branch
from
October 13, 2022 14:01
0ea7561 to
1c344bd
Compare
Contributor
Author
|
Ping @msujew (or shall I request another reviewer?) |
Member
|
Oh, yeah. Taking a look at this tomorrow :) |
msujew
approved these changes
Nov 8, 2022
msujew
left a comment
Member
There was a problem hiding this comment.
Looking at this, I remembered that I already reviewed this. Just didn't approve it yet...
Anyway, the changes look good to me 👍 I can confirm that the issue exists on master and is addressed by the changes nicely.
erezmus
pushed a commit
to ARMmbed/theia
that referenced
this pull request
May 3, 2023
Fixes a bug where context was set by selection rather than item identity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Depends on #11741.
Fixes #11458 by using a transient context for tree view context menus rather than a permanent setting when the selection changes in the tree view.
How to test
Test Viewin the Explorer view container.Review checklist
Reminder for reviewers