Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Add error checks#3219

Merged
eerhardt merged 1 commit intorelease/2.0.0from
signingErrorChecks_2.0
Sep 14, 2017
Merged

Add error checks#3219
eerhardt merged 1 commit intorelease/2.0.0from
signingErrorChecks_2.0

Conversation

@jcagme
Copy link
Copy Markdown

@jcagme jcagme commented Sep 14, 2017

Adding error checks to ensure we fail the build when there are no files to sign

@dnfclas
Copy link
Copy Markdown

dnfclas commented Sep 14, 2017

@jcagme,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@jcagme jcagme added the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 14, 2017
@eerhardt eerhardt removed the * NO MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Sep 14, 2017
@eerhardt
Copy link
Copy Markdown
Member

We aren't planning on shipping a release/2.0.0 build in the near future. We can take this change.

@eerhardt eerhardt merged commit e10d9cf into release/2.0.0 Sep 14, 2017
@eerhardt eerhardt deleted the signingErrorChecks_2.0 branch September 14, 2017 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants