add imageid output and use metadata to set digest output#569
Merged
crazy-max merged 1 commit intodocker:masterfrom Mar 14, 2022
Merged
add imageid output and use metadata to set digest output#569crazy-max merged 1 commit intodocker:masterfrom
crazy-max merged 1 commit intodocker:masterfrom
Conversation
938ae23 to
af70eb7
Compare
tonistiigi
reviewed
Mar 7, 2022
Member
tonistiigi
left a comment
There was a problem hiding this comment.
If this still needs some work maybe separate out the digest part. Only the digest from metadata is needed for the new buildx. Getting image ID output is a new feature and not time critical.
Member
Author
|
@tonistiigi As docker/buildx#980 and docker/buildx#989 are now merged I think we can move forward with this PR and keep imageID output. WDYT? |
af70eb7 to
6b68332
Compare
crazy-max
commented
Mar 9, 2022
bc058cb to
83a1b4f
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
83a1b4f to
50fa005
Compare
tonistiigi
reviewed
Mar 14, 2022
tonistiigi
approved these changes
Mar 14, 2022
jglick
added a commit
to jglick/starter-workflows
that referenced
this pull request
Apr 18, 2022
jglick
added a commit
to cloudbees-oss/inject-metadata-velero-plugin
that referenced
this pull request
Apr 18, 2022
KendrickColeman
pushed a commit
to KendrickColeman/starter-workflows
that referenced
this pull request
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #461
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com