Improve tzname_in_python2 decorator#811
Merged
pganssle merged 2 commits intodateutil:masterfrom Sep 3, 2018
Merged
Conversation
pganssle
added a commit
to pganssle/dateutil
that referenced
this pull request
Sep 2, 2018
9a06fb3 to
20a21df
Compare
This improves the ability to inspect wrapped tzname methods in Python 2 and removes an unnecessary function call (to the nested function) in Python 3. From my measurements, this is about twice as fast in Python 3 and approximately the same speed in Python 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the ability to inspect wrapped tzname methods in Python 2
and removes an unnecessary function call (to the nested function) in
Python 3. From my measurements, this is about twice as fast in Python 3
and approximately the same speed in Python 2.
Pull Request Checklist