Skip to content

Add skip-uncommitted-files-check flag to GH action#70

Merged
heliocodacy merged 2 commits intomasterfrom
add-skip-uncommitted-files-check
Mar 3, 2022
Merged

Add skip-uncommitted-files-check flag to GH action#70
heliocodacy merged 2 commits intomasterfrom
add-skip-uncommitted-files-check

Conversation

@heliocodacy
Copy link
Copy Markdown
Contributor

No description provided.

@heliocodacy heliocodacy changed the title Update action.yml Add skip-uncommitted-files-check flag to GH action Mar 3, 2022
Comment thread action.yml Outdated
Co-authored-by: Joao Machado <machado@codacy.com>
@heliocodacy heliocodacy merged commit 028de6e into master Mar 3, 2022
@heliocodacy heliocodacy deleted the add-skip-uncommitted-files-check branch March 3, 2022 16:04
Comment thread action.yml Outdated
skip-uncommitted-files-check:
required: false
description: >-
skip validation on uncommited files
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤓

Suggested change
skip validation on uncommited files
Skip validation on uncommitted files

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it would be more correct to talk about "uncommitted changes" (as mentioned on the possible status code). This is because a file can have some changes committed and some changes not committed at the same time. But I noticed that the Codacy Analysis CLI already includes the same flag mentioning files. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants