Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ffe9d58:
|
nicolo-ribaudo
approved these changes
Jul 19, 2021
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I don't like this option, but yeah let's at least make it behave correctly.
Contributor
sosukesuzuki
left a comment
There was a problem hiding this comment.
We should update TypeScript definition file for this option.
Member
|
Uh well, it was already defined as an optional |
Contributor
|
Oh sorry I missed it |
existentialism
approved these changes
Jul 20, 2021
Contributor
Author
|
Thanks for merging! |
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
strictModeoption toparse()does not behave as described in the docs.The docs say:
The actual behavior is
strict = options.strictMode === false ? false : options.sourceType === "module";Setting the option to
truehas no effect - contradicting what it says in docs.This PR fixes this so the option behaves as documented, while also preserving the current (undocumented) behavior of allowing
strictMode: falseto overridesourceType: 'module'.I have opted to check for
trueandfalseexplicitly and ignore any other values for the option, rather than accepting other truthy/falsy values. This is intended to make this change less likely to cause unexpected breakage for incorrect configurations e.g.strictMode: "sloppy". But I think anyone who has explicitly saidstrictMode: trueclearly wants that!By the way, this option is useful in some cases. I ran into it because was trying to parse code that was being run in an
eval()which is nested within strict mode code. So it should be parsed as strict mode, but not as a module as there's noimportinsideeval().