Disallow JSX tag forming after TS non-null assertion#13449
Merged
JLHwung merged 1 commit intobabel:mainfrom Jun 10, 2021
Merged
Disallow JSX tag forming after TS non-null assertion#13449JLHwung merged 1 commit intobabel:mainfrom
JLHwung merged 1 commit intobabel:mainfrom
Conversation
JLHwung
commented
Jun 10, 2021
| // When ! is consumed as a postfix operator (non-null assertion), | ||
| // disallow JSX tag forming after. e.g. When parsing `p! < n.p!` | ||
| // `<n.p` can not be a start of JSX tag | ||
| this.state.exprAllowed = false; |
Contributor
Author
There was a problem hiding this comment.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46802/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c376be7:
|
JLHwung
commented
Jun 10, 2021
existentialism
approved these changes
Jun 10, 2021
nicolo-ribaudo
approved these changes
Jun 10, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes regressions introduced in #13431. The token
!hasbeforeExprbecause it can be a prefix operator in a Unary expression. However, when it is consumed as a postfix operator in non-null, we should setbeforeExprtofalse, which is equivalent tostate.exprAllowed = falseso the JSX tag would not form after.This PR also fixes an issue that we are pushing duplicatetc.bracetoken context when JSX plugin is enabled, one is insuper.updateContext, the other is injsxPlugin.updateContext. I am working on a test for this issue.I have removed this commit as it turns out
tt.braceandtt.templateQuasiis unifiable, and whensuper.updateContextpushedtt.brace, thejsxPlugin.updateContextdoes not run at all. I will prepare a PR later.