fix: tagged template incorrect receiver#13395
Merged
JLHwung merged 6 commits intobabel:mainfrom Jun 15, 2021
Merged
Conversation
1 task
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46894/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a0d7ec:
|
Contributor
Author
|
@nicolo-ribaudo Thanks for the comments. General question, Can i create a new commit (fixing review) and push to this PR or do i must keep it with a single commit (using commit --amend with force push)? |
jridgewell
requested changes
May 29, 2021
Member
|
It's fine to add as many commits as needed to this PR. |
sag1v
commented
May 29, 2021
Contributor
Author
|
@nicolo-ribaudo @jridgewell I pushed the new changes per your comments |
Contributor
Author
|
@nicolo-ribaudo / @jridgewell Are we done here? :) |
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I left a few more comments about tests; apart from them it looks good 👍
jridgewell
reviewed
Jun 1, 2021
jridgewell
reviewed
Jun 14, 2021
Member
jridgewell
left a comment
There was a problem hiding this comment.
Sorry, just a few more comments (that I screwed up). If you can make these changes, run update the tests one last time, this should be good to merge.
Contributor
Author
|
@jridgewell Thanks, done. |
jridgewell
approved these changes
Jun 15, 2021
JLHwung
approved these changes
Jun 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.