Don't duplicate the base class when using constantSuper#13303
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom May 14, 2021
Merged
Don't duplicate the base class when using constantSuper#13303nicolo-ribaudo merged 1 commit intobabel:mainfrom
constantSuper#13303nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
May 12, 2021
Comment on lines
+1
to
+5
| var _B; | ||
|
|
||
| class A extends (_B = class B {}) {} | ||
|
|
||
| babelHelpers.defineProperty(A, "x", _B.x); |
Member
Author
There was a problem hiding this comment.
The output was
class A extends class B {} {}
babelHelpers.defineProperty(A, "x", (class B {}).x);which is wrong if the extends clause has side effects or if it has identity.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46132/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f52b06b:
|
7066d76 to
cdb3474
Compare
JLHwung
approved these changes
May 14, 2021
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
For reference, Babel works as expected when the assumption constantSuper is not enabled (default).
existentialism
approved these changes
May 14, 2021
cdb3474 to
f52b06b
Compare
This was referenced May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.