Parse string export names by default (moduleStringNames)#13195
Merged
nicolo-ribaudo merged 2 commits intobabel:feat-7.14.0/parser-updatesfrom Apr 23, 2021
Merged
Conversation
ad09030 to
9370d4c
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45534/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4f77d8:
|
cf45eef to
2d0b249
Compare
9370d4c to
3795942
Compare
jridgewell
approved these changes
Apr 22, 2021
Member
Author
|
Note that we don't have a plugin to transform this. It would be possible to transform imports: import { "a b" as x } from "mod";
x;
// ->
import * as _mod from "mod";
_mod["a b"];but I think that exports are impossible to transpile. |
JLHwung
approved these changes
Apr 23, 2021
9 tasks
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 23, 2021
* Parse string epxort names by default (`moduleStringNames`) * Remove remaining references
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 26, 2021
* Parse string epxort names by default (`moduleStringNames`) * Remove remaining references
nicolo-ribaudo
added a commit
that referenced
this pull request
Apr 28, 2021
* Parse string epxort names by default (`moduleStringNames`) * Remove remaining references
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: tc39/ecma262#2154
This syntax is effectively stage 4. It didn't go through the proposals process, but: