Repository navigation
Conversation
JLHwung
commented
Apr 19, 2021
| @@ -2,7 +2,7 @@ | |||
| "type": "File", | |||
| "start":0,"end":19,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":19}}, | |||
| "errors": [ | |||
| "SyntaxError: `new.target` can only be used in functions. or class properties (1:8)" | |||
| "SyntaxError: `new.target` can only be used in functions or class properties. (1:8)" | |||
Contributor
Author
There was a problem hiding this comment.
Also fixed unexpected . in the error messages lol.
Member
|
Can you remove the plugins from the moved |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45401/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e703c47:
|
JLHwung
commented
Apr 19, 2021
| @@ -1,3 +0,0 @@ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
This commit is created from https://gist.github.com/JLHwung/970c52d63fd3b5ee14e3ada1cd227d33
JLHwung
force-pushed
the
feat-7.14.0/parser-updates
branch
from
April 19, 2021 19:40
4d58f86 to
654ab5a
Compare
JLHwung
force-pushed
the
materialize-class-features
branch
from
April 19, 2021 19:41
f071f02 to
92baa7f
Compare
nicolo-ribaudo
approved these changes
Apr 19, 2021
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
(There is a prettier error)
JLHwung
force-pushed
the
materialize-class-features
branch
from
April 19, 2021 20:22
92baa7f to
4864069
Compare
Contributor
Author
|
@nicolo-ribaudo fixed in 00f84db |
hzoo
reviewed
Apr 20, 2021
| @@ -0,0 +1,63 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
oh I would of expected these tests to be duplicated given they used to throw with the enable parser plugin error (and thus wouldn't be testing the syntax but the plugin), but I guess they are unique actually? Like we would of had a test for asi that didn't throw as well, so you could delete this one.
hzoo
approved these changes
Apr 20, 2021
8 of 9 tasks
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 20, 2021
* feat: materialize class features * chore: move testcases to es2022 * chore: update test fixtures * chore: remove classPr\w+ from options.json * chore: remove empty options.json * update flow test allowlist * update typescript allowlist
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 20, 2021
* feat: materialize class features * chore: move testcases to es2022 * chore: update test fixtures * chore: remove classPr\w+ from options.json * chore: remove empty options.json * update flow test allowlist * update typescript allowlist
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 22, 2021
* feat: materialize class features * chore: move testcases to es2022 * chore: update test fixtures * chore: remove classPr\w+ from options.json * chore: remove empty options.json * update flow test allowlist * update typescript allowlist
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 23, 2021
* feat: materialize class features * chore: move testcases to es2022 * chore: update test fixtures * chore: remove classPr\w+ from options.json * chore: remove empty options.json * update flow test allowlist * update typescript allowlist
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 26, 2021
* feat: materialize class features * chore: move testcases to es2022 * chore: update test fixtures * chore: remove classPr\w+ from options.json * chore: remove empty options.json * update flow test allowlist * update typescript allowlist
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 28, 2021
* feat: materialize class features * chore: move testcases to es2022 * chore: update test fixtures * chore: remove classPr\w+ from options.json * chore: remove empty options.json * update flow test allowlist * update typescript allowlist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following parser plugins will be materialized in Babel 7.14
classPropertiesclassPrivatePropertiesclassPrivateMethods