Implement async-do-expressions transform#13117
Merged
nicolo-ribaudo merged 7 commits intobabel:feat-7.14.0/async-do-expressionsfrom Apr 12, 2021
Merged
Implement async-do-expressions transform#13117nicolo-ribaudo merged 7 commits intobabel:feat-7.14.0/async-do-expressionsfrom
nicolo-ribaudo merged 7 commits intobabel:feat-7.14.0/async-do-expressionsfrom
Conversation
a916a70 to
b1319f1
Compare
Co-authored-by: Brian Ng <bng412@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e03a570:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45101/ |
ceee6d0 to
e03a570
Compare
existentialism
approved these changes
Apr 7, 2021
hzoo
approved these changes
Apr 7, 2021
Member
hzoo
left a comment
There was a problem hiding this comment.
glad implementation seems pretty straightforward! I guess we aren't linking to the proposal repo other than on website?
nicolo-ribaudo
approved these changes
Apr 9, 2021
Member
|
Merging to @JLHwung Could you open a website PR adding a page for this plugin? |
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 12, 2021
Co-authored-by: Brian Ng <bng412@gmail.com>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 20, 2021
Co-authored-by: Brian Ng <bng412@gmail.com>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 28, 2021
Co-authored-by: Brian Ng <bng412@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The transform is derived from
babel/packages/babel-traverse/src/path/replacement.ts
Line 217 in 6d89daf
with changes listed below:
toSequenceExpressioncall, an async arrow closure is always created@babel/parser.yieldwithin the async do blockI avoided extending
NodePath#replaceExpressionWithStatementsbecause of the differences mentioned above and the hazard of breaking other plugins.Additional Context
When working on this PR, I realize that
babel/packages/babel-traverse/src/path/replacement.ts
Line 241 in 6d89daf
/cc @bakkot