Do not load root babel.config.js in tests#13087
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Apr 2, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44973/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c752cbd:
|
hzoo
approved these changes
Apr 2, 2021
Member
hzoo
left a comment
There was a problem hiding this comment.
yeah I'd think we'd only want to apply the config/options from options.json? Do we need to include babelrc: false as well?
nicolo-ribaudo
commented
Apr 2, 2021
jridgewell
approved these changes
Apr 2, 2021
jridgewell
approved these changes
Apr 2, 2021
Member
Author
|
Oh well, good to know that this solves a real problem! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on the native ESM Babel build (wip implementation: https://github.com/nicolo-ribaudo/babel/tree/native-esm), I had to add some
configFile: falseto our tests (you can see them forbabel-coreat nicolo-ribaudo@5d15dc7) because they were accidentally loading the top-levelbabel.config.jsfile.This didn't cause problems so far because our
babel.config.jshas anignoreentry forpackages/*/test/fixtures, but it caused problems for the ESM tests because even if a file is ignored all the plugins/presets are still resolved andrequire'd.Also, tests should be isolated so it's better to make sure that they don't accidentally load an unrelated config anyway.
cc @jridgewell If I recall correctly, AMP uses our test runner plugins. I would consider this PR a bugfix, but would it cause problems to AMP?