Compile classes when spread is unsupported#13075
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Mar 31, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44877/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f074690:
|
jridgewell
approved these changes
Mar 30, 2021
Member
jridgewell
left a comment
There was a problem hiding this comment.
Nit: The PR title is backwards. You're compiling classes when you compile spread, not spread when classes.
Member
Author
|
Ohh, that why I was so confused, thanks! |
JLHwung
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are some firefox versions where one thing between "classes" and "spread" is supported and the other is not. This causes a compilation error.
I bumped the spread data to align them with the classes data. I also wrote a bugfix plugin, but given that the compat data are almost the same probably it's not worth the complexity.
I'm really confused about comparing supported versions (i.e. what supports what), so it's possible that this PR isn't needed and I just interpreted the data in a wrong way.