Remove lodash deps by hzoo · Pull Request #13057 · babel/babel

hzoo · 2021-03-26T16:35:19Z

Inlining the function in most cases

Q	A
Fixed Issues?	Closes #11726, ref #13021
Any Dependency Changes?	Lodash
License	MIT

hzoo · 2021-03-26T16:37:03Z

+      sourceType: "script",
+      babelrc: false,
+      inputSourceMap: task.inputSourceMap || undefined,
+      ...opts,


It doesn't seem like we'd need to deep merge any of the options above so should be equivalent (or are all primitives)

hzoo · 2021-03-26T16:38:06Z

    if (i < countArgs) arg = args[i];
-    if (arg === undefined) arg = loClone(field.default);
+    if (arg === undefined) {
+      arg = Array.isArray(field.default) ? [] : field.default;


in my search, all the default options are primitives except for a default of empty array

We should throw if we see a non-empty array or an object, so that we don't accidentally break this assumption in the future.

ah right, https://lodash.com/docs/#clone seems complicated, maybe we need to check what we do allow instead then given it could be anything?

so string/boolean/null/[]

Yeah, we can just throw if Array.isArray(def) ? def.length > 0 : def && typeof def === "object"

Added check in the other file! https://github.com/babel/babel/pull/13057/files#diff-36b14d40dba9fa52476c9907672a7a9e06a1da66dcc135100a918e956aadd04fR283-R289

babel-bot · 2021-03-26T16:38:26Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44800/

codesandbox-ci · 2021-03-26T16:39:49Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c34d89c:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

nicolo-ribaudo · 2021-03-26T16:40:47Z

  (value: unknown): t.Expression;
 };

+function isRegExp(value): boolean {


Suggested change

function isRegExp(value): boolean {

function isRegExp(value): value is RegExp {

nicolo-ribaudo · 2021-03-26T16:41:39Z


        for (const plugin of pluginConfig) {
-          const camelPlugin = camelCase(plugin);
+          const camelPlugin = plugin.replace(/-([a-z])/g, c =>


Suggested change

const camelPlugin = plugin.replace(/-([a-z])/g, c =>

const camelPlugin = plugin.replace(/-[a-z]/g, c =>

I don't think we need the capturing group here

merceyz · 2021-03-26T16:53:50Z

@@ -20,7 +20,6 @@
    "@babel/helper-fixtures": "workspace:^7.13.10",
    "babel-check-duplicated-nodes": "^1.0.0",
    "escape-string-regexp": "condition:BABEL_8_BREAKING ? ^4.0.0 : ",


Suggested change

"escape-string-regexp": "condition:BABEL_8_BREAKING ? ^4.0.0 : ",

Can remove this as well now since you removed the file that uses it

good catch thanks!!

merceyz · 2021-03-26T16:54:52Z

-"use strict";
-
-module.exports = process.env.BABEL_8_BREAKING
-  ? require("escape-string-regexp")


hzoo · 2021-03-26T22:20:56Z

          delete taskOpts.os;
        }
-        merge(opts, taskOpts);
+        opts = { args: [], ...taskOpts };


Changed this merge too (the only thing replaced is args, which is always set in our tests given it's babel-cli)

nicolo-ribaudo

Thanks!

I love how "inline some deps" results in "more deleted lines than added lines" 😂

julienw · 2021-04-12T08:41:12Z

hey @hzoo @nicolo-ribaudo, is it expected that last version of @babel/cli still depends on lodash ? See https://github.com/babel/babel/blob/main/packages/babel-cli/package.json#L31 :-)
The CHANGELOG file mentions that it's removed from @babel/cli too, hence my question.

Thanks!

inline escapeRegExp instead of using any dep

0cad852

hzoo commented Mar 26, 2021

View reviewed changes

nicolo-ribaudo reviewed Mar 26, 2021

View reviewed changes

merceyz reviewed Mar 26, 2021

View reviewed changes

nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Mar 26, 2021

nicolo-ribaudo reviewed Mar 26, 2021

View reviewed changes

Comment thread Gulpfile.mjs Outdated

hzoo added 4 commits March 26, 2021 18:12

inline camelCase

8a999b1

replace merge with object spread

6bff19c

copy if array instead of using clone

140441c

inline isRegExp

952092c

hzoo force-pushed the remove-deps branch from 528dbb6 to 9638fa3 Compare March 26, 2021 22:19

hzoo commented Mar 26, 2021

View reviewed changes

hzoo added 5 commits March 26, 2021 18:23

review fixes!

e060ed4

remove escape-string-regexp from package.json and in test

aa897f8

add error for field defaults that are not primitives or empty arrays

0639927

replace merge with object spread

9333918

yarn

c34d89c

nicolo-ribaudo approved these changes Mar 26, 2021

View reviewed changes

hzoo force-pushed the remove-deps branch from 9638fa3 to c34d89c Compare March 26, 2021 22:28

existentialism approved these changes Mar 27, 2021

View reviewed changes

nicolo-ribaudo merged commit 6b39baf into babel:main Mar 27, 2021

hzoo mentioned this pull request Apr 11, 2021

Trim down install size by 5 mb by dropping lodash #13134

Closed

1 task

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 13, 2021

github-actions Bot locked as resolved and limited conversation to collaborators Jul 13, 2021

hzoo deleted the remove-deps branch March 3, 2022 04:09

	function isRegExp(value): boolean {
	function isRegExp(value): value is RegExp {

	const camelPlugin = plugin.replace(/-([a-z])/g, c =>
	const camelPlugin = plugin.replace(/-[a-z]/g, c =>

Uh oh!

Conversation

hzoo commented Mar 26, 2021 • edited by nicolo-ribaudo Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

babel-bot commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci Bot commented Mar 26, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

julienw commented Apr 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hzoo commented Mar 26, 2021 •

edited by nicolo-ribaudo

Loading

babel-bot commented Mar 26, 2021 •

edited

Loading

codesandbox-ci Bot commented Mar 26, 2021 •

edited

Loading