fix: the LHS in for-of loop should not start with let#13049
Merged
JLHwung merged 2 commits intobabel:mainfrom Mar 29, 2021
Merged
fix: the LHS in for-of loop should not start with let#13049JLHwung merged 2 commits intobabel:mainfrom
JLHwung merged 2 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44651/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7faa984:
|
nicolo-ribaudo
approved these changes
Mar 24, 2021
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
hzoo
approved these changes
Mar 29, 2021
fisker
added a commit
to prettier/prettier
that referenced
this pull request
Apr 12, 2021
thorn0
added a commit
to prettier/prettier
that referenced
this pull request
Apr 12, 2021
* Build(deps): Bump @babel/parser from 7.13.13 to 7.13.15 Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.13.13 to 7.13.15. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.13.15/packages/babel-parser) Signed-off-by: dependabot[bot] <support@github.com> * Add test for babel/babel#13099 * Test babel/babel#13049 * Test babel/babel#13101 * Add long name test * Style * Print necessary parens in `{ a: (b as any) = 2000 }` Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: fisker Cheung <lionkay@gmail.com> Co-authored-by: Georgii Dolzhykov <thorn.mailbox@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error message is copied from https://cs.chromium.org/chromium/src/v8/src/common/message-template.h.
A new routine
isLetKeywordis extracted fromisLetso we don't introduce extra contextual check oflet.