Skip to content

fix(types): add missing range for BaseNode#13046

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JounQin:fix/range
Mar 24, 2021
Merged

fix(types): add missing range for BaseNode#13046
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JounQin:fix/range

Conversation

@JounQin
Copy link
Copy Markdown
Contributor

@JounQin JounQin commented Mar 24, 2021

Q                       A
Fixed Issues? Fixes #13027
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Unnecessary
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44610/

@codesandbox-ci
Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6bcf5c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JounQin
Copy link
Copy Markdown
Contributor Author

JounQin commented Mar 24, 2021

No idea why test filed. It seems the master branch is broken too, so not related to this PR.

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added pkg: types area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories and removed pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Mar 24, 2021
@nicolo-ribaudo
Copy link
Copy Markdown
Member

Yeah the failure is unrelated, thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 238ce0b into babel:main Mar 24, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Mar 24, 2021
@JounQin JounQin deleted the fix/range branch March 24, 2021 13:27
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 24, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[types] range is missing in BaseNode

4 participants