Fix importing polyfill plugins in the Rollup bundle#13017
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Mar 22, 2021
Merged
Fix importing polyfill plugins in the Rollup bundle#13017nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
9 tasks
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44374/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit df07f0a:
|
JLHwung
approved these changes
Mar 18, 2021
Member
Author
|
Merging since this is just a change in the build config and not in the source itself. I'll revert once rollup/plugins#838 is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The polyfill plugins are ESM files compiled down to CJS, and thus they have an
__esModule: trueproperty.When bundling CJS files that have the
__esModule: trueoption, Rollup matches the default Babel interop and transformsimport foo from "foo"toconst foo = require("foo").default(rather thanconst foo = require("foo"), as Node.js does).This PR introduces a small Babel plugins that rewrites those specific
import footoimport * as foowhen bundling.I opened rollup/plugins#838 to see if the Rollup community is interested in aligning with Node.js.