fix: do not throw when creating type annotation based on bigint#12971
Merged
JLHwung merged 4 commits intobabel:mainfrom Mar 19, 2021
Merged
fix: do not throw when creating type annotation based on bigint#12971JLHwung merged 4 commits intobabel:mainfrom
JLHwung merged 4 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44375/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5eee3af:
|
JLHwung
commented
Mar 5, 2021
| } else if (type === "bigint") { | ||
| // todo: use BigInt annotation when Flow supports BigInt | ||
| // https://github.com/facebook/flow/issues/6639 | ||
| return anyTypeAnnotation(); |
Contributor
Author
There was a problem hiding this comment.
We can not use numberTypeAnnotation here because Math functions do not work with BigInt. Mark it as any as it is not supported in Flow.
nicolo-ribaudo
approved these changes
Mar 6, 2021
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
In the future we could consider moving away from Flow as an internal representation of types.
Closed
1 task
existentialism
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.