fix(ts): parenthesized assert and assign by fedeci · Pull Request #12933 · babel/babel

fedeci · 2021-02-28T09:02:59Z

Q	A
Fixed Issues?	Fixes #12932
Patch: Bug Fix?	Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

We treat ParenthesizedExpression node as a TSAsExpression in #toAssignable() so that the function recurses one more time.

babel-bot · 2021-02-28T09:05:18Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44539/

codesandbox-ci · 2021-02-28T09:06:23Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62dc9f1:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

nicolo-ribaudo

Can you add a test that with the TS plugin and createParenthesizedExpression ({}) = x still throws?

fedeci · 2021-02-28T16:28:52Z

It broke that, what about adding a check like this to the superclass' toAssignable

isParenthesizedAssignable(node) {
  const type = node.type
  return (
    type === "TSParameterProperty" || 
    type === "TSAsExpression" || 
    ... || 
    super.isParenthesizedAssignable(node)
  )
}

Co-Authored-By: Nicolò Ribaudo <7000710+nicolo-ribaudo@users.noreply.github.com>

thorn0 · 2021-03-01T18:24:51Z

+        case "ParenthesizedExpression":
+          if (
+            node.expression.type === "TSAsExpression" ||
+            node.expression.type === "ParenthesizedExpression"


I guess TSNonNullExpression and TSTypeAssertion should be here too

Yes, I tried running some tests on those, but they work like magic😁

JLHwung

Like @thorn0 said, we still need to check for TSNonNullExpression and TSTypeAssertion. It the test is passing maybe there isn't a test which enables createParenthesizedExpressions. Clearly Babel parser 7.12 fails: https://astexplorer.net/#/gist/910487b331a19aac83c5489fa4203e66/4180181cff60d53a164ab16afb82a8e6e7d5698c

The error is thrown from

babel/packages/babel-parser/src/parser/lval.js

Line 91 in efdca01

this.raise(node.start, Errors.InvalidParenthesizedAssignment);

, which assumes that parenthesized assignment can be either identifier / member expression. This is not the cases for TypeScript, where TSNonNullExpression, TSAsExpression and TSTypeAssertion plays a role of transparent expression wrapper, which should have been unwrapped before check. Consider handle this as we did in

babel/packages/babel-helper-skip-transparent-expression-wrappers/src/index.js

Lines 11 to 18 in efdca01

    
           export function isTransparentExprWrapper(node: Node) { 
        
             return ( 
        
               t.isTSAsExpression(node) || 
        
               t.isTSTypeAssertion(node) || 
        
               t.isTSNonNullExpression(node) || 
        
               t.isTypeCastExpression(node) || 
        
               t.isParenthesizedExpression(node) 
        
             );

I think we can also simplifies how we handle toAssignable in the typescript plugin using this helper.

fedeci · 2021-03-01T20:05:07Z

isParenthesizedAssignable(node) {

  const type = node.type

  return (

    type === "TSParameterProperty" || 

    type === "TSAsExpression" || 

    ... || 

    super.isParenthesizedAssignable(node)

  )

}

Maybe I got confused and I tested it with this code which does almost the same of that helper.

JLHwung · 2021-03-18T14:51:04Z

Can you add following test cases with { "createParenthesizedExpressions": true }?

(a!) = null;
(<string>a) = null;

Like Georgii mentioned before, they should not throw.

nicolo-ribaudo · 2021-03-22T15:39:00Z

Thanks!

nicolo-ribaudo

I'll merge this in 15 mins, as soon as the release CI job on main finishes

* Throw errors for invalid left-hand side assignment * Fix tests * FIx tests * Add tests from babel/babel#12933

fix(ts): parenthesized assert and assign

706f94b

nicolo-ribaudo reviewed Feb 28, 2021

View reviewed changes

nicolo-ribaudo added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 28, 2021

nicolo-ribaudo reviewed Feb 28, 2021

View reviewed changes

Comment thread packages/babel-parser/src/plugins/typescript/index.js

Correctly raise error when assigning variable to parenthesized object

1c24ecb

Co-Authored-By: Nicolò Ribaudo <7000710+nicolo-ribaudo@users.noreply.github.com>

thorn0 reviewed Mar 1, 2021

View reviewed changes

JLHwung reviewed Mar 1, 2021

View reviewed changes

Address code review

62dc9f1

JLHwung approved these changes Mar 20, 2021

View reviewed changes

nicolo-ribaudo reviewed Mar 22, 2021

View reviewed changes

nicolo-ribaudo approved these changes Mar 22, 2021

View reviewed changes

nicolo-ribaudo added the ⚠️ Do not merge label Mar 22, 2021

armano2 mentioned this pull request Mar 22, 2021

feat(typescript-estree): add ParenthesizedExpression when surrounded by JSDoc type comment typescript-eslint/typescript-eslint#3135

Closed

nicolo-ribaudo removed the ⚠️ Do not merge label Mar 22, 2021

nicolo-ribaudo merged commit 4f72713 into babel:main Mar 22, 2021

fedeci deleted the fix-parenthesized-assert-and-assign branch March 22, 2021 16:43

fisker mentioned this pull request Mar 29, 2021

Build(deps): Bump @babel/parser from 7.13.11 to 7.13.13 prettier/prettier#10622

Merged

fisker added a commit to fisker/prettier that referenced this pull request Mar 29, 2021

Add tests from babel/babel#12933

fc16db7

thorn0 pushed a commit to prettier/prettier that referenced this pull request Mar 29, 2021

Throw errors for invalid left-hand side assignment (#10416)

24d39a9

* Throw errors for invalid left-hand side assignment * Fix tests * FIx tests * Add tests from babel/babel#12933

github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 22, 2021

github-actions Bot locked as resolved and limited conversation to collaborators Jun 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(ts): parenthesized assert and assign#12933

fix(ts): parenthesized assert and assign#12933
nicolo-ribaudo merged 3 commits intobabel:mainfrom
fedeci:fix-parenthesized-assert-and-assign

fedeci commented Feb 28, 2021 •

edited

Loading

Uh oh!

babel-bot commented Feb 28, 2021 •

edited

Loading

Uh oh!

codesandbox-ci Bot commented Feb 28, 2021 •

edited

Loading

Uh oh!

nicolo-ribaudo left a comment

Uh oh!

fedeci commented Feb 28, 2021

Uh oh!

Uh oh!

thorn0 Mar 1, 2021

Uh oh!

fedeci Mar 1, 2021

Uh oh!

JLHwung left a comment

Uh oh!

fedeci commented Mar 1, 2021

Uh oh!

JLHwung commented Mar 18, 2021 •

edited

Loading

Uh oh!

nicolo-ribaudo commented Mar 22, 2021

Uh oh!

nicolo-ribaudo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	export function isTransparentExprWrapper(node: Node) {
	return (
	t.isTSAsExpression(node) \|\|
	t.isTSTypeAssertion(node) \|\|
	t.isTSNonNullExpression(node) \|\|
	t.isTypeCastExpression(node) \|\|
	t.isParenthesizedExpression(node)
	);

Uh oh!

Conversation

fedeci commented Feb 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

babel-bot commented Feb 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ci Bot commented Feb 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

fedeci commented Feb 28, 2021

Uh oh!

Uh oh!

thorn0 Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

fedeci Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

JLHwung left a comment

Choose a reason for hiding this comment

Uh oh!

fedeci commented Mar 1, 2021

Uh oh!

JLHwung commented Mar 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicolo-ribaudo commented Mar 22, 2021

Uh oh!

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fedeci commented Feb 28, 2021 •

edited

Loading

babel-bot commented Feb 28, 2021 •

edited

Loading

codesandbox-ci Bot commented Feb 28, 2021 •

edited

Loading

JLHwung commented Mar 18, 2021 •

edited

Loading