Reuse the readOnlyError helper for private methods#12792
Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom Feb 12, 2021
Merged
Reuse the readOnlyError helper for private methods#12792nicolo-ribaudo merged 1 commit intobabel:mainfrom
readOnlyError helper for private methods#12792nicolo-ribaudo merged 1 commit intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/40316/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b435598:
|
hzoo
approved these changes
Feb 11, 2021
existentialism
approved these changes
Feb 12, 2021
JLHwung
approved these changes
Feb 12, 2021
This was referenced Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing #12707, I noticed that
classPrivateMethodSetis basically the same asreadOnlyErrorexcept that it doesn't say exactly what cannot be reassigned.The
readOnlyErrorhelper will throw something like"#foo" is read-only", which is also more correct when reassigning a private getter (since it's not technically a method). Also, we avoid injecting two different helpers in the generated bundle.This PR also removes
classPrivateMethodSetfor Babel 8.