babel-parser(ts): Throw recoverable for duplicates access modifier#12775
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Feb 9, 2021
Merged
babel-parser(ts): Throw recoverable for duplicates access modifier#12775nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
Contributor
sosukesuzuki
commented
Feb 6, 2021
| Q | A |
|---|---|
| Fixed Issues? | Fixes #12774 |
| Patch: Bug Fix? | Y |
| Tests Added + Pass? | Yes |
| License | MIT |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 61b3e1f:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39904/ |
Support parsing for duplicates access modifiers
63bcfdb to
849704d
Compare
kaicataldo
approved these changes
Feb 8, 2021
JLHwung
approved these changes
Feb 8, 2021
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
LGTM with some typing nits.
existentialism
approved these changes
Feb 8, 2021
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.