Skip to content

Support destructuring variable declarator within TS namespace#12760

Merged
JLHwung merged 4 commits intobabel:mainfrom
JLHwung:destructuring-in-namespace
Feb 5, 2021
Merged

Support destructuring variable declarator within TS namespace#12760
JLHwung merged 4 commits intobabel:mainfrom
JLHwung:destructuring-in-namespace

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Feb 5, 2021 •
edited by gitpod-io Bot
Loading

Q                       A
Fixed Issues? Fixes #11461
Patch: Bug Fix? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR should be reviewed by commits. It supports general declarator via t.getBindingIdentifiers. The following snippet

namespace Foo
{
    export const {a, b} = obj
}

is now transformed to

let Foo;

(function (_Foo) {
  const {a, b} = obj;
  _Foo.a = a, _Foo.b = b;
})(Foo || (Foo = {}));

Unlike TypeScript which also transpiles patterns even if we target to ESNext, Babel does not transpile and instead it will delegate to @babel/plugin-transform-destructuring for further transpilation if required.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Feb 5, 2021
JLHwung
JLHwung commented Feb 5, 2021
View reviewed changes
Comment thread ...s/babel-plugin-transform-typescript/test/fixtures/namespace/namespace-nested-module/input.ts
const M1 = {}
export module M1 {}
const { M2 } = {}
export module M2 {}
Copy link
Copy Markdown
Contributor Author

@JLHwung JLHwung Feb 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel currently throws for

const { M2 } = {}
export module M2 {}

because M2 is never added to names, and TSModuleDeclaration handler will add M2 variable declarations which collide with const { M2 } = {}.

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Feb 5, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0079773:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Feb 5, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39704/

nicolo-ribaudo
nicolo-ribaudo previously approved these changes Feb 5, 2021
View reviewed changes
@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Feb 5, 2021 •
edited
Loading

Wait, approved too early

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Feb 5, 2021 •
edited
Loading

The CI error is related

@JLHwung JLHwung merged commit 74ed698 into babel:main Feb 5, 2021
@JLHwung JLHwung deleted the destructuring-in-namespace branch February 5, 2021 16:52
@sosukesuzuki sosukesuzuki mentioned this pull request Feb 19, 2021
Merged
14 tasks
This was referenced Mar 11, 2021
Closed
Open
@dependabot dependabot Bot mentioned this pull request Mar 18, 2021
Closed
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 8, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Destructuring assignment not supported in namespaces

4 participants

@JLHwung @babel-bot @nicolo-ribaudo @existentialism