Don't use require() in ESM files#12728
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Feb 1, 2021
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 72d89fd:
|
05413e8 to
72d89fd
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39059/ |
existentialism
approved these changes
Feb 1, 2021
JLHwung
reviewed
Feb 1, 2021
| "packages/babel-compat-data/*.js", | ||
| "packages/*/src/**/*.cjs", | ||
| ], | ||
| }), |
Contributor
There was a problem hiding this comment.
Q: Does the plugin reordering here resolve rollup/plugins#557?
Member
Author
There was a problem hiding this comment.
Yes, I don't get any error now. Btw, I swapped them because it's documented at https://github.com/rollup/plugins/tree/master/packages/babel#using-with-rollupplugin-commonjs
This means that we cannot use flow/TS in cjs files, but I couldn't find another way to make it work.
JLHwung
approved these changes
Feb 1, 2021
This was referenced Mar 8, 2021
chore(deps-dev): bump @babel/plugin-external-helpers from 7.10.4 to 7.12.13
chantouchsek/v-timers#12
Closed
Closed
This was referenced Mar 15, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by #12677.
Since
requireis a normal function in ES modules,rollupdoesn't resolve it and thus the@babel/standalonebundle still containedrequire()calls.This needs to be merged before the next release.
The first commit updates
yarn-plugin-conditions, because nicolo-ribaudo/yarn-plugin-conditions@5b39955 makes it more bundler-friendly.