Skip to content

fix: throw error when accessing private method without a getter#12689

Merged
JLHwung merged 4 commits intobabel:mainfrom
fedeci:fix-class-private-accessor-get
Jan 26, 2021
Merged

fix: throw error when accessing private method without a getter#12689
JLHwung merged 4 commits intobabel:mainfrom
fedeci:fix-class-private-accessor-get

Conversation

@fedeci
Copy link
Copy Markdown
Member

@fedeci fedeci commented Jan 25, 2021 •
edited by gitpod-io Bot
Loading

Q                       A
Fixed Issues? Fixes #12673
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When trying to access a private accessor without a getter method now throws a TypeError instead of just returning undefined.

fedeci
fedeci commented Jan 25, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.js Outdated
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jan 25, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/38413/

@existentialism existentialism added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jan 25, 2021
JLHwung
JLHwung reviewed Jan 25, 2021
View reviewed changes
Comment thread packages/babel-helper-create-class-features-plugin/src/fields.js Outdated
@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jan 25, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 523f9b3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit 5a020b2 into babel:main Jan 26, 2021
nicolo-ribaudo
nicolo-ribaudo reviewed Jan 26, 2021
View reviewed changes
Comment thread packages/babel-helpers/src/helpers.js
@fedeci fedeci deleted the fix-class-private-accessor-get branch January 26, 2021 16:40
@fedeci fedeci mentioned this pull request Jan 26, 2021
Merged
@nicolo-ribaudo nicolo-ribaudo added PR: Spec Compliance 👓 A type of pull request used for our changelog categories and removed PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jan 26, 2021
This was referenced Mar 8, 2021
Closed
Merged
Closed
Closed
Open
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Mar 18, 2021
Closed
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 28, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@jridgewell jridgewell jridgewell approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get operation on private accessor without getter should throw

6 participants

@fedeci @babel-bot @jridgewell @JLHwung @nicolo-ribaudo @existentialism