This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 191a654:

Only took me 3/4 of a year to follow up on the issue 🙈

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41471/

I don't think NodePath#referencesImport should extend to named imports because it is mutable, although the imported namespace binding is constant. For example

import * as ns from "some-module";
ns.foo = "foo";

// error: can not reassign "ns"
ns = anotherNs

Should NodePath("ns.foo").referencesImport("some-module", "foo") return true? While we are sure * is a referenced import from "some-module", we don't know if "foo" is exported from "some-module" without looking into the exports of "some-module".

@JLHwung as far as I know, this is not the case? Maybe I'm missing something.
At least in Node 14.15.1, which I've used to test, trying to override an existing namespace property fails with

TypeError: Cannot assign to read only property 'prop' of object '[object Module]'

and trying to add one fails with

TypeError: Cannot add property prop2, object is not extensible

I've checked the spec and these 'module namespace exotic objects' are indeed non-extensible, and their [[Set]] does nothing but Returns false. Phew, for a moment I was scared that the spec actually allowed mutating them, which would be terrible for anyone who wants to do some static analysis 😅

Both done - lmk if this needs anything else

The failing e2e tests are not related, and are probably caused by a slightly old base branch.

Would you like me to rebase?

Yes please!

Done, it seems this was because it was based off of master, because my repo was from before the main branch name change