Skip to content

fix: cloneNode(deep, withoutLoc) handles absent comments#12602

Merged
JLHwung merged 1 commit intobabel:mainfrom
FauxFaux:fix/clone-fragments
Jan 13, 2021
Merged

fix: cloneNode(deep, withoutLoc) handles absent comments#12602
JLHwung merged 1 commit intobabel:mainfrom
FauxFaux:fix/clone-fragments

Conversation

@FauxFaux
Copy link
Copy Markdown
Contributor

@FauxFaux FauxFaux commented Jan 10, 2021 •
edited by gitpod-io Bot
Loading

Q                       A
Fixed Issues? This one. 😄
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link No
Any Dependency Changes? No
License MIT

This fragment (maybe all fragments?) throw during cloneNode() with deep and withoutLoc.

foo();

comments is unset here. Handle it being unset, by passing through the undefined.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jan 10, 2021 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37189/

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Jan 10, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f21a48b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Copy Markdown
Member

nicolo-ribaudo commented Jan 10, 2021

Can you modify maybeCloneComments to return deep && withoutLoc && comments ? cloneCommentsWithoutLoc(comments) : comments instead?

And also if you know TS please add type annotations to maybeCloneComments's params, so that it's clear that comments might be absent 🙏

@nicolo-ribaudo nicolo-ribaudo added pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jan 10, 2021
@FauxFaux
fix: cloneNode(deep, withoutLoc) handles absent comments
f21a48b 
This fragment (maybe all fragments?) throw during cloning, as
'comments' is unset here. Handle it being unset, by returning
undefined.
@FauxFaux FauxFaux force-pushed the fix/clone-fragments branch from a95f58f to f21a48b Compare January 10, 2021 16:06
@FauxFaux
Copy link
Copy Markdown
Contributor Author

FauxFaux commented Jan 10, 2021

Done.

@FauxFaux FauxFaux marked this pull request as ready for review January 11, 2021 05:57
nicolo-ribaudo
nicolo-ribaudo approved these changes Jan 13, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit bd4590e into babel:main Jan 13, 2021
@FauxFaux FauxFaux deleted the fix/clone-fragments branch January 13, 2021 05:48
This was referenced Mar 8, 2021
Closed
Merged
Closed
Closed
Open
Closed
Closed
This was referenced Mar 15, 2021
Closed
Closed
Closed
Merged
Closed
Closed
Closed
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 15, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FauxFaux @babel-bot @nicolo-ribaudo @JLHwung