Use isIdentifierChar instead of regex for toIdentifier#12575
Merged
JLHwung merged 6 commits intobabel:mainfrom Dec 31, 2020
Merged
Use isIdentifierChar instead of regex for toIdentifier#12575JLHwung merged 6 commits intobabel:mainfrom
JLHwung merged 6 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/36641/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bdc6b36:
|
merceyz
reviewed
Dec 31, 2020
JLHwung
reviewed
Dec 31, 2020
JLHwung
reviewed
Dec 31, 2020
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
mischnic
commented
Dec 31, 2020
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Can you add a test with a name whose first character is a valid identifier char, but not a valid identifier start?
Contributor
Author
|
@nicolo-ribaudo I've added |
Member
|
I was thinking more about something non in the ASCII range, like expect(t.toIdentifier("\u0487a")).toBe(...) |
existentialism
approved these changes
Dec 31, 2020
This was referenced Mar 8, 2021
chore(deps-dev): bump @babel/plugin-external-helpers from 7.10.4 to 7.12.13
chantouchsek/v-timers#12
Closed
Closed
This was referenced Mar 15, 2021
Closed
This was referenced Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non ASCII-chars that are still valid in an identifier were previously removed (so valid identifiers were turned into
_). UseisIdentifierCharinstead as suggested in #12574 (comment)