Fix small typo#11682
Merged
JLHwung merged 1 commit intobabel:masterfrom Jun 5, 2020
sajadtorkamani:task/fix-typo
Merged
Conversation
Contributor
sajadtorkamani
commented
Jun 5, 2020
| Q | A |
|---|---|
| Fixed Issues? | |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
Contributor
|
Can you run |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e578668:
|
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/23550/ |
Contributor
Author
I ran this from the project root and all the tests passed (after a while!) but nothing else changed. Running |
Contributor
|
@sajadtorkamani Thanks. Ideally there should be a test covering this branch, but it is not blocking this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.