Skip to content

chore: download compat-table when build-data is run#10873

Merged
existentialism merged 2 commits intobabel:masterfrom
JLHwung:remove-compat-table-dependency
Dec 18, 2019
Merged

chore: download compat-table when build-data is run#10873
existentialism merged 2 commits intobabel:masterfrom
JLHwung:remove-compat-table-dependency

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Dec 17, 2019

Q                       A
Fixed Issues? improve yarn install a little bit
Any Dependency Changes? compat-table is removed from npm dev dependencies, it is never officially published, though
License MIT

This PR removes compat-table dev dependencies so that all of its dependencies, which intends to build compat-table website, can be skipped during yarn install.

@JLHwung JLHwung added PR: Internal 🏠 A type of pull request used for our changelog categories pkg: preset-env labels Dec 17, 2019
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should move all the scripts to the root of the monorepo, so that it's easier to know which scripts exist.

(Not in this PR)

@existentialism existentialism merged commit ff8a295 into babel:master Dec 18, 2019
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 18, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants