Use async-to-generator even when regenerator is enabled#10839
Merged
JLHwung merged 1 commit intobabel:masterfrom Dec 9, 2019
Merged
Use async-to-generator even when regenerator is enabled#10839JLHwung merged 1 commit intobabel:masterfrom
async-to-generator even when regenerator is enabled#10839JLHwung merged 1 commit intobabel:masterfrom
Conversation
While it isn't technically needed because regenerator already handles
async functions, it doesn't play well with the Promise detection logic
used by @babel/preset-env's useBuiltIns and @babel/transform-runtime.
The plugin exclusion logic isn't removed, because
1) it will be useful when merging @babel/preset-modules
into @babel/preset-env
2) if/when regenerator will support injecting a custom promise,
we can enable this optimization again
existentialism
approved these changes
Dec 8, 2019
JLHwung
reviewed
Dec 9, 2019
JLHwung
approved these changes
Dec 9, 2019
rwjblue
pushed a commit
to rwjblue/ember-cli-babel
that referenced
this pull request
Dec 20, 2019
This reverts commit b31980e. The change that required this was reverted in babel/babel#10839.
|
@nicolo-ribaudo I just updated @babel/core to be some example code: const onClose = async () => {
try {
await <thing that returns a promise>;
} catch (err) {
return;
}
}
};and is called from a click handler in a different react component. my package.json for babel related things in a custom preset: and in the app that uses this preset I have |
|
reverting back to 7.7.5 allows it to work again. |
Member
Author
|
Did it work before 7.7.0? If it did, then it's caused by some other change. Could you open a new issue? 🙏 |
|
it did, last week we were on 7.7.5 and this week updated. i'll open a new issue and link back to this one. |
|
core, preset env and runtime all got bumped recently so it could be one of those as well. this pr was in the change log and seemed related. |
1 task
|
@nicolo-ribaudo opened new issue. #10928 |
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 18, 2020
This was referenced Mar 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
async-to-generatorit isn't technically needed becauseregeneratoralready handles async functions, it doesn't play well with thePromisedetection logic used by@babel/preset-env'suseBuiltInsand@babel/transform-runtime.The plugin exclusion logic isn't removed, because
@babel/preset-modulesinto@babel/preset-envThis PR effectively reverts the behavior introduced in #9481