fix(optional chaining): Optional delete returns true with nullish base#10806
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Dec 4, 2019
Merged
Conversation
Per issue 10805, the return value when using delete on a nullish base is currently undefined. The correct return type should be true.
jridgewell
approved these changes
Dec 4, 2019
| test = obj === null || obj === void 0 ? void 0 : delete obj.a.b; | ||
| test = obj === null || obj === void 0 ? void 0 : (_obj$b = obj.b) === null || _obj$b === void 0 ? void 0 : delete _obj$b.b; | ||
| obj === null || obj === void 0 ? void 0 : delete obj.a; | ||
| let test = obj === null || obj === void 0 ? true : (_obj$a = obj.a) === null || _obj$a === void 0 ? true : delete _obj$a.b; |
This was referenced Feb 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per issue #10805, the return value when using delete on a nullish base is
currently undefined. The correct return type should be true.