Allow tuple rest trailing comma#10800
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Dec 3, 2019
yeonjuan:fix-rest-tuple-trailing-comma
Merged
Allow tuple rest trailing comma#10800nicolo-ribaudo merged 1 commit intobabel:masterfrom yeonjuan:fix-rest-tuple-trailing-comma
nicolo-ribaudo merged 1 commit intobabel:masterfrom
yeonjuan:fix-rest-tuple-trailing-comma
Conversation
Contributor
yeonjuan
commented
Dec 3, 2019
| Q | A |
|---|---|
| Fixed Issues? | Fixes #10769 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
| this.checkCommaAfterRest(charCodes.rightSquareBracket); | ||
| if ( | ||
| this.match(tt.comma) && | ||
| this.lookaheadCharCode() !== charCodes.rightSquareBracket |
Member
There was a problem hiding this comment.
Is there already a test for when ...a, is not followed by ]?
Contributor
Author
There was a problem hiding this comment.
JLHwung
approved these changes
Dec 3, 2019
existentialism
approved these changes
Dec 3, 2019
Member
|
Thanks! |
This was referenced Feb 22, 2020
This was referenced Mar 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.