Skip to content

fix: remove ExportNamedDeclaration when the specifier is empty#10638

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
JLHwung:fix-10634
Nov 4, 2019
Merged

fix: remove ExportNamedDeclaration when the specifier is empty#10638
nicolo-ribaudo merged 1 commit intobabel:masterfrom
JLHwung:fix-10634

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Nov 4, 2019

Q                       A
Fixed Issues? Fixes #10634
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

The ExportNamedDeclaration should be removed when its specifiers are empty.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: modules labels Nov 4, 2019
@buildsize
Copy link
Copy Markdown

buildsize Bot commented Nov 4, 2019

File name Previous Size New Size Change
babel-preset-env.js 2.77 MB 2.77 MB 0 bytes (0%)
babel-preset-env.min.js 1.67 MB 1.67 MB 0 bytes (0%)
babel.js 2.95 MB 2.95 MB 59 bytes (0%)
babel.min.js 1.63 MB 1.63 MB 15 bytes (0%)
test262.tap 4.84 MB [deleted]

@nicolo-ribaudo nicolo-ribaudo merged commit 5e24016 into babel:master Nov 4, 2019
@JLHwung JLHwung deleted the fix-10634 branch November 5, 2019 03:06
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Merged
This was referenced Nov 28, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Merged
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Open
@lock lock Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 4, 2020
@lock lock Bot locked as resolved and limited conversation to collaborators Feb 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: modules outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[plugin-transform-modules-systemjs] does not resolve export {};

3 participants

@JLHwung @existentialism @nicolo-ribaudo