fix: add computed property support for object Ref#10863
Merged
nicolo-ribaudo merged 3 commits intobabel:masterfrom Dec 19, 2019
Merged
fix: add computed property support for object Ref#10863nicolo-ribaudo merged 3 commits intobabel:masterfrom
nicolo-ribaudo merged 3 commits intobabel:masterfrom
Conversation
JLHwung
commented
Dec 12, 2019
| @@ -0,0 +1,20 @@ | |||
| var key, x, y, z; | |||
Contributor
Author
There was a problem hiding this comment.
This test case is revised from
nicolo-ribaudo
approved these changes
Dec 18, 2019
existentialism
approved these changes
Dec 18, 2019
Co-Authored-By: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Member
|
The failing tests are fixed in master |
This was referenced Feb 22, 2020
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add support for computed properties when generating
objRefforobject-rest-spread. In the following exampleHere the
objRefisobj.prop, which is the parent path of the rest element...x. Apparentlyobj.propis incorrect because[prop]is a computed property. This is fixed by addingcomputedargument when buildingt.memberExpressionforobjRef.However, the computed properties could be impure: which means we could not evaluate these properties twice. Therefore we refactored the interface of
replaceImpureComputedKeysand reuse it to cache the computed properties.Note that although this PR only addresses #6341 (comment), #6341 can also be closed after merging this PR because I can not reproduce OP's issue on REPL. (link)