Use scope flags to check arguments#10801
Merged
nicolo-ribaudo merged 2 commits intobabel:masterfrom Dec 5, 2019
Merged
Conversation
Co-authored-by: Jens Maier<jens@elberet.de>
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Can you add a test with arrow functions?
class A {
x = () => arguments;
}
Contributor
Author
existentialism
approved these changes
Dec 5, 2019
nicolo-ribaudo
approved these changes
Dec 5, 2019
This was referenced Feb 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce
inClassaccessor inScopeHandlerand use it to checkargumentskeyword. Please refer to this thread for the background.