Add support to clear custom dimensions and configure flush behavior on dimensions#105
Merged
Stephen-Bao merged 8 commits intoawslabs:masterfrom Aug 17, 2022
Merged
Conversation
paggynie
reviewed
Jul 25, 2022
paggynie
reviewed
Jul 26, 2022
paggynie
reviewed
Jul 26, 2022
markkuhn
reviewed
Jul 26, 2022
markkuhn
reviewed
Jul 26, 2022
markkuhn
reviewed
Jul 26, 2022
markkuhn
approved these changes
Aug 3, 2022
This was
linked to
issues
Aug 10, 2022
paggynie
approved these changes
Aug 16, 2022
Contributor
paggynie
left a comment
There was a problem hiding this comment.
just a minor comment that we can mention in README that customer only need to set once for setFlushPreserveDimensions(false) per metrics logger. right now customer may get confused to set it everytime before flush
added 8 commits
August 16, 2022 10:20
… preserve dimensions after each flush
95af752 to
a732313
Compare
paggynie
approved these changes
Aug 16, 2022
Contributor
|
Will this feature be added to the other EMF libraries? |
This was referenced Aug 19, 2022
Closed
Closed
Closed
This was referenced Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#35, #91
Description of changes:
Added a resetDimensions(boolean useDefault) method for clearing custom dimensions; added a boolean field to MetricsLogger to control the behavior of whether to preserve custom dimensions after each flush(); adjusted README to reflect the correct behavior of flush() and new method.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.