[SUREFIRE-2032] Fix test count when using @Disabled at class level#564
Merged
gnodet merged 2 commits intoapache:masterfrom Dec 23, 2022
Merged
[SUREFIRE-2032] Fix test count when using @Disabled at class level#564gnodet merged 2 commits intoapache:masterfrom
gnodet merged 2 commits intoapache:masterfrom
Conversation
olamy
approved these changes
Sep 20, 2022
Member
|
Let me try this... |
Member
|
I have now built and installed M8-SNAPSHOT, but cannot confirm that it is fixed: with |
slawekjaranowski
approved these changes
Dec 19, 2022
Contributor
|
I can confirm that this PR fixes the issue for the setup of the original reporter at least - although I had to modify the setup slightly, making the abstract class an inner class, making the implementations non-static and adding package surefire2032;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
public class Test1 {
@Tag("red")
@Nested
public class RedTest extends TagTest {
}
@Disabled
@Tag("orange")
@Nested
public class OrangeTest extends TagTest {
}
abstract class TagTest {
@Test
public void test1() {
// Do Nothing
}
@Test
public void test2() {
// Do Nothing
}
}
}Console output: XML output: |
slawekjaranowski
approved these changes
Dec 22, 2022
8 tasks
|
Resolve #2619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for http://issues.apache.org/jira/browse/SUREFIRE-2032, which cause a display issue with apache/maven-integration-testing#176.