[SUREFIRE-2101] - Fixes 'null' phrased test names with JUnit5 without @DisplayName#549
Merged
slawekjaranowski merged 1 commit intoapache:masterfrom Dec 27, 2022
Merged
Conversation
When phrased test names are enabled, but an annotation such as DisplayName in JUnit5 is missing from the test, the output to the console will now fall back to using the original name rather than naming the test 'null'.
Contributor
|
This pull request fixes the issue for the JUnit5StatelessTestsetInfoReporter, but not for the JUnit5ConsoleOutputReporter. You can see that in the output of the JUnitPlatformEnginesIT#testJupiterEngineWithDisplayNames. It still has "Running null" in it with your fix. The reason it doesn't work there is that you adjusted the behaviour for the CategorizedReportEntry and the WrappedReportEntry, but not for the SimpleReportEntry. I've made an alternative pull request #587 that fixes it in a single place, the TestSetStats class. I think that's more robust. |
Member
|
@ascopes thanks |
|
Resolve #2836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When phrased test names are enabled, but an annotation such as DisplayName
in JUnit5 is missing from the test, the output to the console will now
fall back to using the original name rather than naming the test
'null'.
This amends this behaviour to provide a more meaningful name in these scenarios,
which can be important when migrating a large code base over to using
phrased names incrementally.
An example of the existing output which can be problematic:
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0
As of Sunday 19th June 2022, I have submitted a signed copy of the Apache ICLA to
mailto:secretary@apache.orgin PDF form.