Skip to content

[SUREFIRE-2057] jpms requires static must be included#508

Merged
Tibor17 merged 2 commits intomasterfrom
SUREFIRE-2057-jpms-requires-static-not-included
Apr 15, 2022
Merged

[SUREFIRE-2057] jpms requires static must be included#508
Tibor17 merged 2 commits intomasterfrom
SUREFIRE-2057-jpms-requires-static-not-included

Conversation

@olamy
Copy link
Copy Markdown
Member

@olamy olamy commented Apr 4, 2022

Signed-off-by: Olivier Lamy olamy@apache.org

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy added the bug Something isn't working label Apr 4, 2022
Signed-off-by: Olivier Lamy <olamy@apache.org>
@Tibor17 Tibor17 self-requested a review April 6, 2022 09:48
@Tibor17 Tibor17 merged commit 541a65d into master Apr 15, 2022
@Tibor17 Tibor17 deleted the SUREFIRE-2057-jpms-requires-static-not-included branch April 15, 2022 11:39
@jira-importer
Copy link
Copy Markdown

Resolve #3111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants