Conversation
|
@slawekjaranowski |
| <parent> | ||
| <groupId>org.apache.maven.surefire</groupId> | ||
| <artifactId>surefire</artifactId> | ||
| <version>3.0.0-M6-SNAPSHOT</version> | ||
| </parent> |
There was a problem hiding this comment.
is indentation correct ... looks like change from 2 -> 4 space?
There was a problem hiding this comment.
4 is correct
I am using Maven profile in IDEA.
There was a problem hiding this comment.
@slawekjaranowski
But maven-shared-utils has CLI class, platform specific impl. We need it. Other classes are minor. If we could extract only that as sources and not bytecode, and if we substituted DirectoryScanner with NIO Files, then yes, it would be possible to get right of shaded classes.
There was a problem hiding this comment.
There is not much methods and classes we use, we can write our own, few util methods. The problem is with CLI.
There was a problem hiding this comment.
There was a problem hiding this comment.
I thought about surefire-shared-utils not maven-shared-utils ...
I now there are place where we must shade package from maven-shared-utils and other but I hope it can be done in the last module in the tree where maven-shared-utils is used ... but it is another story
There was a problem hiding this comment.
@slawekjaranowski
We shade the maven-shared-utils into surefire-shared-utils, and much more.
I can imaging the dependency maven-shared-utils with type sources extracting CLI classes to generated sources, and adding new DirectoryScanner based on NIO in src/main/java. This can be done but you need to have a spare time to write unit tests for the scaner and several trivial utility methods.
|
@slawekjaranowski |
…ls in Report Parser. Removed commons-lang in Report Plugin.
6253914 to
79ae093
Compare
|
@slawekjaranowski |
|
Resolve #2805 |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
[ x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.