Skip to content

[3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version#670

Merged
gnodet merged 2 commits intoapache:maven-3.8.xfrom
gnodet:MNG-6727-3.8.x
Feb 1, 2022
Merged

[3.8.x][MNG-6727] Changed expression check to project.version and project.parent.version#670
gnodet merged 2 commits intoapache:maven-3.8.xfrom
gnodet:MNG-6727-3.8.x

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented Jan 31, 2022

Based on #427 with an additional fix/test for pom.version and pom.parent.version.

jmax01 and others added 2 commits January 31, 2022 17:16
# Conflicts:
#	maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
@gnodet gnodet requested a review from michael-o January 31, 2022 18:54
Copy link
Copy Markdown
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase, edit to "[MNG-6727] Using version range in parent and CI Friendly Version fails" and merge into 3.8.x and master.

Thank you!

@gnodet gnodet merged commit d79485f into apache:maven-3.8.x Feb 1, 2022
@jira-importer
Copy link
Copy Markdown

Resolve #8308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants