[refactor] use utility method of Objects to simplify code#284
Merged
olamy merged 2 commits intoapache:masterfrom Sep 10, 2019
Merged
[refactor] use utility method of Objects to simplify code#284olamy merged 2 commits intoapache:masterfrom
olamy merged 2 commits intoapache:masterfrom
Conversation
olamy
requested changes
Sep 4, 2019
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.*; |
Contributor
Author
There was a problem hiding this comment.
@olamy thanks for review.I have modified the code as your suggestion.
| import java.util.Map; | ||
| import java.util.Properties; | ||
| import java.util.Set; | ||
| import java.util.*; |
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.*; |
| import java.util.Iterator; | ||
| import java.util.Map; | ||
| import java.util.Properties; | ||
| import java.util.*; |
olamy
approved these changes
Sep 10, 2019
Member
olamy
left a comment
There was a problem hiding this comment.
LGTM ezy changes with simplified code
rfscholte
approved these changes
Sep 10, 2019
Contributor
|
@caidezhi next time please run |
Contributor
Author
|
@rfscholte I am sorry that the pull request cause some inconveniences (forget that my IDEA setting is "-Dcheckstyle.skip=true"). I will follow the process in future. Many thanks for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use utility method ( Objects.equals ) to rewrite some equals logic in code base.