Skip to content

fix(prepare): destFile path separator#1455

Merged
erisu merged 1 commit intoapache:masterfrom
erisu:fix/src-dest-not-same-error
Jul 4, 2022
Merged

fix(prepare): destFile path separator#1455
erisu merged 1 commit intoapache:masterfrom
erisu:fix/src-dest-not-same-error

Conversation

@erisu
Copy link
Copy Markdown
Member

@erisu erisu commented Jul 4, 2022

Motivation and Context

Resolves #1454

Description

Update the destFile variable to use the correct platform-specific path segment separators.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added the bug label Jul 4, 2022
@erisu erisu added this to the 11.0.1 milestone Jul 4, 2022
@erisu erisu requested a review from breautek July 4, 2022 05:14
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 4, 2022 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.25%. Comparing base (f38e8eb) to head (5fd8aee).
⚠️ Report is 163 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1455   +/-   ##
=======================================
  Coverage   72.25%   72.25%           
=======================================
  Files          21       21           
  Lines        1748     1748           
=======================================
  Hits         1263     1263           
  Misses        485      485

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

NiklasMerz
NiklasMerz approved these changes Jul 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@erisu erisu merged commit e5b7e8a into apache:master Jul 4, 2022
@erisu erisu deleted the fix/src-dest-not-same-error branch July 4, 2022 13:27
@NelsonChad
Copy link
Copy Markdown

NelsonChad commented Aug 11, 2022

Hi ,when i run cordova platform add android@11.0.0 I'm getting this error in prepare.js file

TypeError: Cannot read properties of null (reading 'find')
at E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:387:49
at Array.forEach (<anonymous>)
at updateProjectSplashScreen (E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:384:7)
at updateProjectAccordingTo (E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:269:5)
at E:\DEV\IONIC\donateApp_cord\node_modules\cordova-android\lib\prepare.js:67:21
at processTicksAndRejections (node:internal/process/task_queues:96:5)
at async Promise.all (index 0)
[ERROR] An error occurred while running subprocess cordova.

can you help me please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

@breautek breautek breautek approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

11.0.1

Development

Successfully merging this pull request may close these issues.

Error Messages: {Source and destination must not be the same} cannot build using cordova-android@11.0.0

5 participants

@erisu @codecov-commenter @NelsonChad @NiklasMerz @breautek