feat(AndroidManifest): explicitly define the activity attribute android:exported#1372
Merged
erisu merged 1 commit intoapache:masterfrom Oct 28, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1372 +/- ##
=======================================
Coverage 73.15% 73.15%
=======================================
Files 21 21
Lines 1643 1643
=======================================
Hits 1202 1202
Misses 441 441 Continue to review full report at Codecov.
|
dpogue
approved these changes
Oct 28, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Explicitly define the
android:exportedattribute on the Activty within the AndroidManifest.Previously, this attribute did not need to be explicitly defined but start in Android 12 it will need to be.
It is safe to add this to the current major as it does not introduce a breaking change.
Description
Adds the
android:exported="true"to the activity attributeTesting
Checklist