chore: display warning on deprecated <splash> tag usage#1451
Merged
erisu merged 2 commits intoapache:masterfrom Jun 30, 2022
Merged
chore: display warning on deprecated <splash> tag usage#1451erisu merged 2 commits intoapache:masterfrom
erisu merged 2 commits intoapache:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1451 +/- ##
==========================================
- Coverage 72.52% 72.41% -0.11%
==========================================
Files 21 21
Lines 1740 1744 +4
==========================================
+ Hits 1262 1263 +1
- Misses 478 481 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NiklasMerz
approved these changes
Jun 30, 2022
Member
NiklasMerz
left a comment
There was a problem hiding this comment.
This works.
Looks like I get these warnings twice but I think this is ok
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Users may still use old tag.
Description
Display a warning to migate to the new preference tag when
<splash>tag is used.This only checks for slash tags in
platform[name="androidas global tags could still be used in other platforms.Testing
cordova buildChecklist
(platform)if this change only applies to one platform (e.g.(android))