Clarify CloudEvent.source property meaning#25992
Merged
xiangyan99 merged 1 commit intoAzure:mainfrom Sep 2, 2022
Merged
Conversation
This caused me much confusion: the source should not contain the domain name, it should contain the domain topic (name).
|
Thank you for your contribution waltervos! We will review the pull request and get back to you soon. |
tjprescott
approved these changes
Sep 1, 2022
Member
|
/check-enforcer override |
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
This caused me much confusion: the source should not contain the domain name, it should contain the domain topic (name).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This caused me much confusion: the source should not contain the domain name, it should contain the domain topic (name). As far as I can tell, this particular comment was not generated from the swagger definition (I couldn't find it anywhere else on github anyway).
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines