Skip to content

Fix a typo in docs#40501

Merged
balazsorban44 merged 2 commits intovercel:canaryfrom
janklimo:patch-1
Sep 13, 2022
Merged

Fix a typo in docs#40501
balazsorban44 merged 2 commits intovercel:canaryfrom
janklimo:patch-1

Conversation

@janklimo
Copy link
Copy Markdown
Contributor

@janklimo janklimo commented Sep 13, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

balazsorban44
balazsorban44 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 merged commit c11310b into vercel:canary Sep 13, 2022
balazsorban44 added a commit that referenced this pull request Sep 13, 2022
@balazsorban44
add Balázs as codeowner to /errors/ directory
e6ed8ef 
Ref: #40501
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

1 more reviewer

@balazsorban44 balazsorban44 balazsorban44 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janklimo @balazsorban44 @ijjk